pull_requests.md 2.3 KB
Pull Request process
Pull Requests in the openshift-ansible project follow a
Continuous
Integration
process that is similar to the process observed in other repositories such as
origin.
Whenever a Pull Request is opened, all automated test jobs must be successfully run before the PR can be merged.
Some of these jobs are automatically triggered, e.g., Travis. Other jobs need to be manually triggered by a member of the Team OpenShift Ansible Contributors.
Triggering tests
Members of the Team OpenShift Ansible
Contributors
can trigger test jobs by adding a comment containing
/ok-to-test. For a full list of bot commands refer to the Bot Command
Help.
Triggering merge
After a PR is properly reviewed and all test are passing, it can be
tagged for merge by a member of the Team OpenShift Ansible
Contributors
by writing a comment containing /lgtm (looks good to me) anywhere in
the comment body.
Tagging a Pull Request with /lgtm puts it in an automated merge
queue. The
@openshift-ci-robot monitors
the queue and merges PRs that pass all of the required tests.
Only members of the Team OpenShift Ansible Committers can perform manual merges.
Useful links
- Repository containing Jenkins job definitions: https://github.com/openshift/aos-cd-jobs
- List of required successful jobs before merge: https://github.com/openshift/aos-cd-jobs/blob/master/sjb/test_status_config.yml
- Source code of the bot responsible for testing and merging PRs: https://github.com/openshift/test-pull-requests/
- Trend of the time taken by merge jobs: https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/buildTimeTrend