Merge pull request #8846 from vrutkovs/openshift_master_identity_providers-check-order

Openshift master identity providers check improvements

roles/lib_utils/action_plugins/sanity_checks.py

@@ -380,17 +380,19 @@ class ActionModule(ActionBase):
         kind HTPasswdPasswordIdentityProvider and
         openshift_master_manage_htpasswd is False"""
 
-        idps = self.template_var(
-            hostvars, host, 'openshift_master_identity_providers')
-        if not idps:
-            # If we don't find any identity_providers, nothing for us to do.
-            return None
         manage_pass = self.template_var(
             hostvars, host, 'openshift_master_manage_htpasswd')
         if to_bool(manage_pass):
             # If we manage the file, we can just generate in the new path.
             return None
+        idps = self.template_var(
+            hostvars, host, 'openshift_master_identity_providers')
+        if not idps:
+            # If we don't find any identity_providers, nothing for us to do.
+            return None
         old_keys = ('file', 'fileName', 'file_name', 'filename')
+        if not isinstance(idps, list):
+            raise errors.AnsibleModuleError("| not a list")
         for idp in idps:
             if idp['kind'] == 'HTPasswdPasswordIdentityProvider':
                 for old_key in old_keys: