Merge pull request #729 from detiber/handlerRefactor

Avoid hardcoded 30s pauses

roles/openshift_master/handlers/main.yml

@@ -1,4 +1,4 @@
 ---
 - name: restart master
   service: name={{ openshift.common.service_type }}-master state=restarted
-  when: not openshift_master_ha | bool
+  when: (not openshift_master_ha | bool) and (not master_service_status_changed | default(false))

roles/openshift_master/tasks/main.yml

@@ -141,9 +141,8 @@
   when: not openshift_master_ha | bool
   register: start_result
 
-- name: pause to prevent service restart from interfering with bootstrapping
-  pause: seconds=30
-  when: start_result | changed
+- set_fact:
+    master_service_status_changed = start_result | changed
 
 - name: Install cluster packages
   yum: pkg=pcs state=present

roles/openshift_node/handlers/main.yml

@@ -1,6 +1,7 @@
 ---
 - name: restart node
   service: name={{ openshift.common.service_type }}-node state=restarted
+  when: not node_service_status_changed | default(false)
 
 - name: restart docker
   service: name=docker state=restarted

roles/openshift_node/tasks/main.yml

@@ -128,6 +128,5 @@
   service: name={{ openshift.common.service_type }}-node enabled=yes state=started
   register: start_result
 
-- name: pause to prevent service restart from interfering with bootstrapping
-  pause: seconds=30
-  when: start_result | changed
+- set_fact:
+    node_service_status_changed = start_result | changed