Fix lint

playbooks/byo/openshift-management/add_many_container_providers.yml

@@ -26,16 +26,6 @@
     with_items: "{{ container_providers }}"
     register: results
 
-  # TODO: Make this prettier and easier to read
-  - name: Save results
-    copy:
-      dest: /tmp/results.json
-      content: "{{ results.results | to_nice_json }}"
-      # state: present
-    # debug:
-    #   var: item.item
-    # with_items: "{{ results.results }}"
-
   # Include openshift_management for access to filter_plugins.
   - include_role:
       name: openshift_management

roles/openshift_management/filter_plugins/oo_management_filters.py

@@ -1,5 +1,9 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
+"""
+Filter methods for the management role
+"""
+
 
 def oo_filter_container_providers(results):
     """results - the result from posting the API calls for adding new
@@ -8,14 +12,15 @@ providers"""
     for result in results:
         if 'results' in result['json']:
             # We got an OK response
-            r = result['json']['results'][0]
-            all_results.append("Provider '{}' - Added successfully".format(r['name']))
+            res = result['json']['results'][0]
+            all_results.append("Provider '{}' - Added successfully".format(res['name']))
         elif 'error' in result['json']:
             # This was a problem
             all_results.append("Provider '{}' - Failed to add. Message: {}".format(
                 result['item']['name'], result['json']['error']['message']))
     return all_results
 
+
 class FilterModule(object):
     """ Custom ansible filter mapping """