瀏覽代碼

Remove incorrect validation for OpenIDIdentityProvider

Currently, OpenIDIdentityProvider does not support
'challenge=true' in openshift-ansible.

This is incorrect, the auth plugin OpenIDIdentityProvider
does support this.

This commit removes the unnecessary validation of
challenge key.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1444367
Fixes: https://github.com/openshift/openshift-ansible/issues/4417
Michael Gugino 7 年之前
父節點
當前提交
9879c765a5
共有 1 個文件被更改,包括 0 次插入1 次删除
  1. 0 1
      roles/openshift_master_facts/filter_plugins/openshift_master.py

+ 0 - 1
roles/openshift_master_facts/filter_plugins/openshift_master.py

@@ -363,7 +363,6 @@ class OpenIDIdentityProvider(IdentityProviderOauthBase):
 
 
     def validate(self):
     def validate(self):
         ''' validate this idp instance '''
         ''' validate this idp instance '''
-        IdentityProviderOauthBase.validate(self)
         if not isinstance(self.provider['claims'], dict):
         if not isinstance(self.provider['claims'], dict):
             raise errors.AnsibleFilterError("|failed claims for provider {0} "
             raise errors.AnsibleFilterError("|failed claims for provider {0} "
                                             "must be a dictionary".format(self.__class__.__name__))
                                             "must be a dictionary".format(self.__class__.__name__))