Browse Source

Use return_value when value is constant

Thanks to Tim Bielawa for pointing it out.
Pierre-Louis Bonicoli 8 years ago
parent
commit
93a979aa93
1 changed files with 2 additions and 8 deletions
  1. 2 8
      roles/lib_openshift/src/test/unit/test_oc_adm_registry.py

+ 2 - 8
roles/lib_openshift/src/test/unit/test_oc_adm_registry.py

@@ -241,15 +241,9 @@ class RegistryTest(unittest.TestCase):
             (0, '', ''),
         ]
 
-        mock_tmpfile_copy.side_effect = [
-            '/tmp/mocked_kubeconfig',
-            '/tmp/mocked_kubeconfig',
-        ]
+        mock_tmpfile_copy.return_value = '/tmp/mocked_kubeconfig'
 
-        mock_oc_binary.side_effect = [
-            'oc',
-            'oc',
-        ]
+        mock_oc_binary.return_value = 'oc'
 
         results = Registry.run_ansible(params, False)