Ensure atomic hosts prepull node image during pre-upgrade

Currently, atomic hosts do not prepull the node image
during pre-upgrade step.  This commit refactors image
prepulling to ensure it happens at the approriate times
for both install and upgrades and properly accounts for
atomic host.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1629558

roles/openshift_node/handlers/main.yml

@@ -1,4 +1,9 @@
 ---
+- name: reload systemd units
+  command: systemctl daemon-reload
+  when:
+  - (not skip_node_svc_handlers | default(False) | bool)
+
 - name: restart NetworkManager
   systemd:
     name: NetworkManager
@@ -13,8 +18,3 @@
     state: restarted
   when:
   - (not skip_node_svc_handlers | default(False) | bool)
-
-- name: reload systemd units
-  command: systemctl daemon-reload
-  when:
-  - (not skip_node_svc_handlers | default(False) | bool)

roles/openshift_node/tasks/config.yml

@@ -26,15 +26,3 @@
 - name: include aws provider credentials
   import_tasks: aws.yml
   when: not (openshift_node_use_instance_profiles | default(False))
-
-- name: Check status of node image pre-pull
-  async_status:
-    jid: "{{ image_prepull.ansible_job_id }}"
-  register: job_result
-  until: job_result.finished
-  when:
-  - node_image.stdout_lines == []
-  - not openshift_is_atomic | bool
-  retries: 20
-  delay: 30
-  failed_when: false

roles/openshift_node/tasks/copy_image_to_ostree.yml

@@ -0,0 +1,9 @@
+---
+- name: Copy node container image to ostree storage
+  command: >
+    atomic pull --storage=ostree docker:{{ osn_image }}
+  register: pull_result
+  retries: 3
+  delay: 5
+  until: pull_result.rc == 0
+  changed_when: "'Pulling layer' in pull_result.stdout"

roles/openshift_node/tasks/main.yml

@@ -59,6 +59,11 @@
 
 - import_tasks: registry_auth.yml
 
+- import_tasks: prepull_check.yml
+
+- import_tasks: copy_image_to_ostree.yml
+  when: openshift_is_atomic | bool
+
 - name: include standard node config
   import_tasks: config.yml
 

roles/openshift_node/tasks/node_system_container.yml

@@ -16,27 +16,6 @@
   - "/var/lib/kubelet"
   - "/opt/cni/bin"
 
-- name: Check status of node image pre-pull
-  async_status:
-    jid: "{{ image_prepull.ansible_job_id }}"
-  register: job_result
-  until: job_result.finished
-  when:
-  - node_image is defined
-  - node_image.stdout_lines == []
-  retries: 20
-  delay: 30
-  failed_when: false
-
-- name: Copy node container image to ostree storage
-  command: >
-    atomic pull --storage=ostree docker:{{ osn_image }}
-  register: pull_result
-  retries: 3
-  delay: 5
-  until: pull_result.rc == 0
-  changed_when: "'Pulling layer' in pull_result.stdout"
-
 - import_tasks: node_system_container_install.yml
 
 # TODO: network manager on RHEL is failing to execute 99-origin-dns.sh with signal 13, an immediate

roles/openshift_node/tasks/prepull.yml

@@ -14,3 +14,19 @@
   async: 600
   poll: 0
   register: image_prepull
+
+- name: Check that pod image is present
+  command: "{{ openshift_container_cli }} images -q {{ osn_pod_image }}"
+  register: pod_image
+
+# This task runs async to save time while other downloads proceed
+- name: pre-pull pod image
+  docker_image:
+    name: "{{ osn_pod_image }}"
+  environment:
+    NO_PROXY: "{{ openshift.common.no_proxy | default('') }}"
+  when: pod_image.stdout_lines == []
+  # 10 minutes to pull the image
+  async: 600
+  poll: 0
+  register: pod_image_prepull

roles/openshift_node/tasks/prepull_check.yml

@@ -0,0 +1,22 @@
+---
+- name: Check status of node image pre-pull
+  async_status:
+    jid: "{{ image_prepull.ansible_job_id }}"
+  register: job_result
+  until: job_result.finished
+  when:
+  - node_image.stdout_lines == []
+  - not openshift_is_atomic | bool
+  retries: 20
+  delay: 30
+  failed_when: false
+
+- name: Check status of node pod image pre-pull
+  async_status:
+    jid: "{{ pod_image_prepull.ansible_job_id }}"
+  register: job_result
+  until: job_result.finished
+  when: pod_image.stdout_lines == []
+  retries: 20
+  delay: 30
+  failed_when: false

roles/openshift_node/tasks/systemd_units.yml

@@ -17,6 +17,5 @@
   import_tasks: node_system_container.yml
   when: openshift_is_atomic | bool
 
-
 - import_tasks: config/configure-node-settings.yml
 - import_tasks: configure-proxy-settings.yml

roles/openshift_node/tasks/upgrade.yml

@@ -4,7 +4,6 @@
 # - openshift_is_atomic
 # - node_config_hook
 # - openshift_pkg_version
-# - openshift_release
 
 # tasks file for openshift_node_upgrade
 
@@ -70,9 +69,11 @@
     msg: "Restarting dnsmasq"
   # changed_when: True required for debug tasks to trigger handlers.
   changed_when: True
-  notify: restart dnsmasq
+  notify:
+  - reload systemd units
+  - restart dnsmasq
 
-# Need to flush handlers here so dnsmasq is restarted.
+# Need to flush handlers here so dnsmasq is restarted and daemon-reload
 - meta: flush_handlers
 
 # Restart all services

roles/openshift_node/tasks/upgrade/config_changes.yml

@@ -38,11 +38,3 @@
     line: pause_image = "{{ openshift_crio_pause_image }}"
     regexp: '^pause_image ='
   when: crio_conf.stat.exists == True
-
-# NOTE: This is needed to make sure we are using the correct set
-#       of systemd unit files. The RPMs lay down defaults but
-#       the install/upgrade may override them in /etc/systemd/system/.
-# NOTE: We don't use the systemd module as some versions of the module
-#       require a service to be part of the call.
-- name: Reload systemd units
-  command: systemctl daemon-reload

roles/openshift_node/tasks/upgrade_pre.yml

@@ -7,21 +7,8 @@
 
 - import_tasks: registry_auth.yml
 
-- name: Check that pod image is present
-  command: "{{ openshift_container_cli }} images -q {{ osn_pod_image }}"
-  register: pod_image
-
-# This task runs async to save time while other downloads proceed
-- name: pre-pull pod image
-  docker_image:
-    name: "{{ osn_pod_image }}"
-  environment:
-    NO_PROXY: "{{ openshift.common.no_proxy | default('') }}"
-  when: pod_image.stdout_lines == []
-  # 10 minutes to pull the image
-  async: 600
-  poll: 0
-  register: pod_image_prepull
+# Prepull the node and pod image, it's used by lots of components
+- import_tasks: prepull.yml
 
 - name: update package meta data to speed install later.
   command: "{{ ansible_pkg_mgr }} makecache"
@@ -52,12 +39,7 @@
 - import_tasks: upgrade/rpm_upgrade.yml
   when: not openshift_is_atomic | bool
 
-- name: Check status of node pod image pre-pull
-  async_status:
-    jid: "{{ pod_image_prepull.ansible_job_id }}"
-  register: job_result
-  until: job_result.finished
-  when: pod_image.stdout_lines == []
-  retries: 20
-  delay: 30
-  failed_when: false
+- import_tasks: prepull_check.yml
+
+- import_tasks: copy_image_to_ostree.yml
+  when: openshift_is_atomic | bool