Browse Source

Only try to yaml.load a file if it ends in .yml or .yaml in logging facts

Eric Wolinetz 7 years ago
parent
commit
74730c4260
1 changed files with 4 additions and 3 deletions
  1. 4 3
      roles/openshift_logging/library/openshift_logging_facts.py

+ 4 - 3
roles/openshift_logging/library/openshift_logging_facts.py

@@ -208,9 +208,10 @@ class OpenshiftLoggingFacts(OCBaseCommand):
     def facts_from_configmap(self, comp, kind, name, config_key, yaml_file=None):
         '''Extracts facts in logging namespace from configmap'''
         if yaml_file is not None:
-            config_facts = yaml.load(yaml_file)
-            self.facts[comp][kind][name][config_key] = config_facts
-            self.facts[comp][kind][name]["raw"] = yaml_file
+            if config_key.endswith(".yml") or config_key.endswith(".yaml"):
+                config_facts = yaml.load(yaml_file)
+                self.facts[comp][kind][name][config_key] = config_facts
+                self.facts[comp][kind][name][config_key]["raw"] = yaml_file
 
     def facts_for_configmaps(self, namespace):
         ''' Gathers facts for configmaps in logging namespace '''