Remove extra atomic checks

This commit removes redundant checks for detecting
if host is atomic or not.

roles/etcd/tasks/backup/backup.yml

@@ -27,12 +27,7 @@
 # For non containerized we should have the correct version of
 # etcd installed already. So don't do anything.
 #
-# For containerized installs we now exec into etcd_container
-
-- name: Detecting Atomic Host Operating System
-  stat:
-    path: /run/ostree-booted
-  register: l_ostree_booted
+# For static pod installs we now exec into etcd_container
 
 - name: Check selinux label of '{{ etcd_data_dir }}'
   command: >

roles/openshift_excluder/tasks/main.yml

@@ -1,9 +1,4 @@
 ---
-- name: Detecting Atomic Host Operating System
-  stat:
-    path: /run/ostree-booted
-  register: ostree_booted
-
 - block:
 
   - name: Debug r_openshift_excluder_enable_docker_excluder
@@ -30,4 +25,4 @@
     include_tasks: "{{ r_openshift_excluder_action }}.yml"
 
   when:
-  - not ostree_booted.stat.exists | bool
+  - not openshift_is_atomic

roles/openshift_repos/tasks/main.yaml

@@ -1,10 +1,6 @@
 ---
-- name: openshift_repos detect ostree
-  stat:
-    path: /run/ostree-booted
-  register: ostree_booted
 
-- when: not ostree_booted.stat.exists
+- when: not openshift_is_atomic
   block:
   # TODO: This needs to be removed and placed into a role
   - name: Ensure libselinux-python is installed

roles/os_firewall/tasks/firewalld.yml

@@ -3,7 +3,7 @@
   fail:
     msg: "Firewalld is not supported on Atomic Host"
   when:
-    - r_os_firewall_is_atomic | bool
+    - openshift_is_atomic | bool
     - not openshift_enable_unsupported_configurations | default(false)
 
 - name: Install firewalld packages
@@ -12,7 +12,7 @@
     state: present
   register: result
   until: result is succeeded
-  when: not r_os_firewall_is_atomic | bool
+  when: not openshift_is_atomic | bool
 
 - name: Ensure iptables services are not enabled
   systemd:

roles/os_firewall/tasks/iptables.yml

@@ -23,7 +23,7 @@
   with_items:
     - iptables
     - iptables-services
-  when: not r_os_firewall_is_atomic | bool
+  when: not openshift_is_atomic | bool
   register: result
   until: result is succeeded
 

roles/os_firewall/tasks/main.yml

@@ -1,13 +1,4 @@
 ---
-- name: Detecting Atomic Host Operating System
-  stat:
-    path: /run/ostree-booted
-  register: r_os_firewall_ostree_booted
-
-- name: Set fact r_os_firewall_is_atomic
-  set_fact:
-    r_os_firewall_is_atomic: "{{ r_os_firewall_ostree_booted.stat.exists }}"
-
 - import_tasks: firewalld.yml
   when:
   - os_firewall_enabled | bool