Merge pull request #5932 from mgugino-upstream-stage/retry-docker-creds

Automatic merge from submit-queue.

Add retry logic to docker auth credentials

This commit enables retry on docker login commands.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1506931

roles/docker/tasks/registry_auth.yml

@@ -7,6 +7,10 @@
 
 - name: Create credentials for docker cli registry auth
   command: "docker --config={{ docker_cli_auth_config_path }} login -u {{ oreg_auth_user }} -p {{ oreg_auth_password }} {{ oreg_host }}"
+  register: openshift_docker_credentials_create_res
+  retries: 3
+  delay: 5
+  until: openshift_docker_credentials_create_res.rc == 0
   when:
   - oreg_auth_user is defined
   - (not docker_cli_auth_credentials_stat.stat.exists or oreg_auth_credentials_replace) | bool

roles/openshift_master/tasks/registry_auth.yml

@@ -11,6 +11,9 @@
   - oreg_auth_user is defined
   - (not master_oreg_auth_credentials_stat.stat.exists or oreg_auth_credentials_replace) | bool
   register: master_oreg_auth_credentials_create
+  retries: 3
+  delay: 5
+  until: master_oreg_auth_credentials_create.rc == 0
   notify:
   - restart master api
   - restart master controllers

roles/openshift_node/tasks/registry_auth.yml

@@ -11,6 +11,9 @@
     - oreg_auth_user is defined
     - (not node_oreg_auth_credentials_stat.stat.exists or oreg_auth_credentials_replace) | bool
   register: node_oreg_auth_credentials_create
+  retries: 3
+  delay: 5
+  until: node_oreg_auth_credentials_create.rc == 0
   notify:
     - restart node
 

roles/openshift_node_upgrade/tasks/registry_auth.yml

@@ -11,6 +11,9 @@
     - oreg_auth_user is defined
     - (not node_oreg_auth_credentials_stat.stat.exists or oreg_auth_credentials_replace) | bool
   register: node_oreg_auth_credentials_create
+  retries: 3
+  delay: 5
+  until: node_oreg_auth_credentials_create.rc == 0
   notify:
     - restart node