Remove openshift_clock role

This commit removes the openshift_clock role, which
may be called various times throughout the deployment
as it is needed by various components.

This commit moves the clock bits to init/base_packages.yml
which is called by prerequisites.

playbooks/init/base_packages.yml

@@ -6,6 +6,25 @@
   hosts: "{{ l_base_packages_hosts | default('oo_all_hosts') }}"
   any_errors_fatal: true
   tasks:
+  - name: Determine if chrony is installed
+    command: rpm -q chrony
+    failed_when: false
+    register: chrony_installed
+
+  # chrony is installed on atomic host by default, so no need to worry about
+  # atomic here.
+  - name: Install ntp package
+    package: name=ntp state=present
+    when:
+    - openshift_clock_enabled | default(True) | bool
+    - chrony_installed.rc != 0
+    register: result
+    until: result is succeeded
+
+  - name: Start and enable ntpd/chronyd
+    command: timedatectl set-ntp true
+    when: openshift_clock_enabled | default(True) | bool
+
   - when:
     - not openshift_is_atomic | bool
     block:

playbooks/openshift-etcd/private/ca.yml

@@ -1,8 +1,6 @@
 ---
 - name: Generate new etcd CA
   hosts: oo_first_etcd
-  roles:
-  - role: openshift_clock
   tasks:
   - import_role:
       name: etcd

playbooks/openshift-etcd/private/config.yml

@@ -20,8 +20,6 @@
   any_errors_fatal: true
   tasks:
   - import_role:
-      name: openshift_clock
-  - import_role:
       name: etcd
     vars:
       etcd_peers: "{{ groups.oo_etcd_to_config | default([], true) }}"

playbooks/openshift-master/private/config.yml

@@ -105,7 +105,6 @@
 
   roles:
   - role: openshift_master_facts
-  - role: openshift_clock
   - role: openshift_cloud_provider
     when: openshift_cloudprovider_kind is defined
   - role: openshift_builddefaults

playbooks/openshift-node/private/configure_nodes.yml

@@ -10,7 +10,6 @@
                                                 | lib_utils_oo_collect('openshift.common.hostname') | default([]) | join (',')
                                                 }}"
   roles:
-  - role: openshift_clock
   - role: openshift_cloud_provider
     when: openshift_cloudprovider_kind is defined
   - role: openshift_node

roles/openshift_clock/defaults/main.yml

@@ -1,2 +0,0 @@
----
-openshift_clock_enabled: True

roles/openshift_clock/meta/main.yml

@@ -1,14 +0,0 @@
----
-galaxy_info:
-  author: Jeremiah Stuever
-  description: OpenShift Clock
-  company: Red Hat, Inc.
-  license: Apache License, Version 2.0
-  min_ansible_version: 1.9
-  platforms:
-  - name: EL
-    versions:
-    - 7
-  categories:
-  - cloud
-dependencies: []

roles/openshift_clock/tasks/main.yaml

@@ -1,17 +0,0 @@
----
-- name: Determine if chrony is installed
-  command: rpm -q chrony
-  failed_when: false
-  register: chrony_installed
-
-- name: Install ntp package
-  package: name=ntp state=present
-  when:
-    - openshift_clock_enabled | bool
-    - chrony_installed.rc != 0
-  register: result
-  until: result is succeeded
-
-- name: Start and enable ntpd/chronyd
-  command: timedatectl set-ntp true
-  when: openshift_clock_enabled | bool