Update to Openshift 3.5 (#325)

* Deprecate Iscsi and add registry storage account

* Cleanup of additional storage references

* Enable the launch of the development instance

* setup scripts to support forking and upstream via user

* Fix registry storage account name

* Fix development branch to be master on the upstream

* Fix infranode default vmsize

* Fix vmsize

* Pass the registry storage key to bastion

* Move to reference for registrystorage

* Fix Reference

* Fixup registry key parameter

* Remove output section

* Fix parameters on bastion

* Fix depends storage name

* Move to array reference for keys

* Fix storage api version for keys for registry

* Change to samcogan style reference

* Fix paren

* Add registryConnect to parameters

* Move the grabbing the keys to bastion level

* Fix case

* Fix branch

* Fix up listkeys reference

* Fix storage name

* Fix Mispelling

* Switch from variable to parameter

* Fix case issue and simpilfy

* Fix reference

* Fix missing parameter

* Found bug - ListKeys not supported in variable - moved to parameter

* Add in accountname, and restructure yum installs plus add in nodejs for azure cli and scripting

* Fixup order and remove force

* Do direct references

* Remote quotes and verify values recieved for registry

* Add additional debug

* replace with bash for setup script

* Add array processing to work arround bash bug

* Add all the variables needed for pv/pvc creation using azure

* Build registry and ocp azure configs

* Run the setupregistry playbook

* Remove misc reference

* Fix install script parens

* Fix epel for sendmail

* Fix quota to work on all nodes

* Fix quota

* Fix typo on openshift.local.volumes

* Change order on quota setup

* Fix sendmail

* Move to 7.3

* Work around resource disk move about bug with ansible error recovery

* Start move of quota to node based accounts

* Cleanup zerovg script and make sure all ocp have it

* remove docker-storage-setup command, but update file for ansible scripts use

* Make sure updateok is last

* Roll back to 7.2 because of rhn issues

* Fix to handle multiple open disk in node setup scripts

* Get rid of setupregistry yml and do direct

* Initial setup for azure pvc

* Add autorun of azure setup

* Change to short host names to be compatible with azure pvc

* Fix module path to include openshift ansible library

* Fix azure-pvc-setup output path

* Fix hanging issue on azure pvc setup

* Update default sizes to Standard_DS4_v2

* Add storage accounts for azure pvc

* Add top level availability sets

* Fix bastion size to be in variable and smaller

* Fix newStorageAccountVolume1 that was missing

* Fix api version

* Fix redundant host groups

* disable running the azure pvc script for testing

* Reduce to 1 node and 1 master

* Fixup to do all masters and nodes for azure

* Revert to rhel 7.3

* Change the azure pvc setup to 1, and initial implementation of master lb, and master av set

* Fix openshiftMasterHostname name issue

* Fix openshiftMasterPublicIpDnsLabel

* Fix paren issue

* Fix openshiftMasterPublicIpDnsLabel issue

* Fix openshiftInfraHostname

* Cleanup InfraLbPublicIpDnsLabel

* Fix nested parameter

* Add api versions into variables

* Fix openshiftMasterPublicIpDnsLabel

* Remove duplicate wildcardzone entry

* Add missing parameters to master2 and 3

* Fix parameter

* Add infranode load balancer and avset

* Add nod avset and cleanup order of variables and resources

* Fix domain issue on api

* Fix fulldomain

* Limit to one master update at a time

* Timed setup of nodes

* Add great time between restarts

* Fix escapes for loop in pvc deploy

* Fix node counter

* Fix escapes

* Revert "Fix escapes"

This reverts commit 72987c30438196a8b939d7ea4ca35f96f5b74035.

* Change to short hostnames using generated /etc/hosts

* Test using dnsmasq configured by ocp

* Fixup to allow dnsmasq to do forward and reverse lookup to enable azure storage to function properly

* Fix to make sure bastion is included

* Break the bastion updates and the rest of nodes

* Get rid of redundant lines and use better host selection for /etc/host and dnsmasq updates

* Fix nodenames on master and node

* Get rid of timing and pacing for azure pvc setup

* Add direct node name statements in /etc/ansible/hosts

* Switch to OCP 3.5

* Try 3.5 without storage setup

* Add back etcd for 3.5

* Cleanup node name references

* Add workaround to delete nodes so they can recreate

* Fixup so defers_to will work

* Add nip.io for wildcard domain

* Cleanup output section

* Fix NIP

* Fix extra paren on resource name

* Cleanup storage names

* Fix IP Address for router

* Add in script to create vhd container

* Fixup vhds for azure pv

* fix sending log via email

* Move creating storage profile earlier

* Remove pips from masters

* Fix up master.json to remove pip reference

* Cleanup Log when Mailed

* Cleanup up name used to send mail

* Remove all reference to pip

* Remove pip from infranode

* Remove pip references from parameters

* Cleanup on depends to make deploy more consistent

* Add some sleep to make sure network stable

* Fix storage class substitution

* Fixup to make sure masters are unschedulable

* Remove extranous line

* Make sure the set schedulable is last

* Fix switch on adm

* Prep for upstream commit